Add support for delegating write to split target #136241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…itRequestOnSourceTwoPass Refresh
…com:ankikuma/elasticsearch into 09162025/ReshardSplitRequestOnSourceTwoPass merged
…itRequestOnSourceTwoPass Refresh
…com:ankikuma/elasticsearch into 09162025/ReshardSplitRequestOnSourceTwoPass pull
…itRequestOnSourceTwoPass Refresh
…itRequestOnSourceTwoPass Refresh
…itRequestOnSourceTwoPass Refresh
…itRequestOnSourceTwoPass Refresh
…com:ankikuma/elasticsearch into 09162025/ReshardSplitRequestOnSourceTwoPass Pull
…itRequestOnSourceTwoPass Refresh
…com:ankikuma/elasticsearch into ankikuma-09162025/ReshardSplitRequestOnSourceTwoPass
Tim-Brooks
added
>non-issue
:Distributed Indexing/CRUD
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
elasticsearchmachine
added
the
serverless-linked
…hardSplitRequestOnSourceTwoPass
…hardSplitRequestOnSourceTwoPass
ankikuma
reviewed
Oct 10, 2025
...r/src/main/java/org/elasticsearch/action/support/replication/TransportReplicationAction.java
Outdated
Show resolved
Hide resolved
lkts
approved these changes
Oct 10, 2025
server/src/main/java/org/elasticsearch/action/bulk/ShardBulkSplitHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/bulk/ShardBulkSplitHelper.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
Outdated
Show resolved
Hide resolved
|
LGTM |
ankikuma
approved these changes
Oct 10, 2025
…hardSplitRequestOnSourceTwoPass
…hardSplitRequestOnSourceTwoPass
bcully
approved these changes
Oct 14, 2025
server/src/main/java/org/elasticsearch/action/bulk/ShardBulkSplitHelper.java
Show resolved
Hide resolved
| } | ||
| } | ||
| BulkShardResponse bulkShardResponse = new BulkShardResponse(originalRequest.shardId(), bulkItemResponses); | ||
| // TODO: Decide how to handle |
There was a problem hiding this comment.
I think you looked at consumers of this? If so could you leave a breadcrumb to your investigation? If not, we should ticket that and link the ticket here.
There was a problem hiding this comment.
server/src/main/java/org/elasticsearch/action/support/replication/ReplicationSplitHelper.java
Show resolved
Hide resolved
| new ShardId(index, newShardId), | ||
| shardNum -> new ArrayList<>() | ||
| ); | ||
| shardRequests.add(new BulkItemRequest(bulkItemRequest.id(), bulkItemRequest.request())); |
There was a problem hiding this comment.
should we assert anything about the shard id in bulkItemRequest.request()? From skimming code I think it's probably null (thin serialization) but I don't know if it always is, or how it would be used if it's not null.
There was a problem hiding this comment.
server/src/main/java/org/elasticsearch/cluster/routing/IndexRouting.java
Show resolved
Hide resolved
| } | ||
| return indexShard(indexRequest); | ||
| } else if (addIdWithRoutingHash) { | ||
| // TODO: is this correct? |
There was a problem hiding this comment.
we're probably going to have to generate test cases for tsdb/logsdb
There was a problem hiding this comment.
.../src/test/java/org/elasticsearch/action/support/replication/ReplicationSplitHelperTests.java
Outdated
Show resolved
Hide resolved
Kubik42
pushed a commit
to Kubik42/elasticsearch
that referenced
this pull request
Oct 16, 2025
This commit adds the logic to delegate bulk shard requests to the split target when a primary receives a request from a stale coordinator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the logic to delegate bulk shard requests to the split
target when a primary receives a request from a stale coordinator.